(front) add switch camera on mobile #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NathanVss
commented
Dec 16, 2024
•
NathanVss
commented
- Add switch camera button
- Remove chevron from toggle switches
NathanVss
force-pushed
the
feat/responsive-controlbar-buttons
branch
from
5b4420c to
6804b4a
Compare
NathanVss
changed the title
NathanVss
force-pushed
the
feat/responsive-controlbar-buttons
branch
3 times, most recently
from
9594594 to
9c896ba
Compare
|
I cannot test this button. Will test the functionality on staging. |
|
The number of participant feels a bit far away from its icon. 
|
|
These margins feel redundant 
|
|
Let's try aligning the icon? 
|
| @@ -176,6 +177,7 @@ export function MobileControlBar({ | |||
| > | |||
| <RiSettings3Line size={20} /> | |||
| </Button> | |||
| <CameraSwitchButton onPress={() => setIsMenuOpened(false)} /> | |||
There was a problem hiding this comment.
could we find a way to avoid displaying this button if the user is using a desktop device?
There was a problem hiding this comment.
This component is shown only on mobile device, it cannot be on desktop
NathanVss
force-pushed
the
feat/responsive-controlbar-buttons
branch
2 times, most recently
from
4bb0e01 to
d4e6232
Compare
On mobile we want to be able to hide the chevron and menu.
We want to have a more simple control bar and give the user to switch its back / front camera from the responsive menu.
NathanVss
force-pushed
the
feat/responsive-controlbar-buttons
branch
from
d4e6232 to
b01c3f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.